fix(page): fix section spacing #6766
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,5 @@ | ||
| /* Because the page component has height:100dvh, override it just for the embedded examples */ | ||
| .ws-mdx-content-content [id^=ws-core-c-page-] .ws-preview-html .pf-v6-c-page { | ||
| height: min-content; | ||
| min-height: 30em; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -65,11 +65,11 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| --#{$page}__main-container--BorderColor: var(--#{$page}__main-container--BackgroundColor); // TODO Border should match the background to blend in - change to be a page outline token | ||
|
|
||
| // Main section | ||
| --#{$page}__main-section--PaddingBlockStart: var(--pf-t--global--spacer--md); | ||
| --#{$page}__main-section--PaddingInlineEnd: var(--pf-t--global--spacer--lg); // This is the intended spacing - the border of the main section will be subtracted | ||
| --#{$page}__main-section--PaddingBlockEnd: var(--pf-t--global--spacer--md); | ||
| --#{$page}__main-section--PaddingInlineStart: var(--pf-t--global--spacer--lg); // This is the intended spacing - the border of the main section will be subtracted | ||
| --#{$page}__main-section--RowGap: var(--pf-t--global--spacer--lg); | ||
| --#{$page}__main-breadcrumb--main-section--PaddingBlockStart: var(--pf-t--global--spacer--md); | ||
| --#{$page}__main-section--BackgroundColor: var(--pf-t--global--background--color--primary--default); | ||
| --#{$page}__main-section--m-secondary--BackgroundColor: var(--pf-t--global--background--color--secondary--default); | ||
|
|
@@ -79,6 +79,12 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| // Limit width | ||
| --#{$page}--section--m-limit-width--MaxWidth: calc(#{pf-size-prem(2000px)} - var(--#{$page}__sidebar--Width)); | ||
|
|
||
| // Page main body | ||
| --#{$page}__main-body--MarginBlockStart: 0; | ||
| --#{$page}__main-body--MarginBlockEnd: 0; | ||
| --#{$page}__main-body--PaddingInlineEnd: 0; | ||
| --#{$page}__main-body--PaddingInlineStart: 0; | ||
|
There was a problem hiding this comment. Do we still need these? As far as I can tell, doesn't look like they're ever modified. Padding is on the outer |
||
|
|
||
| // Sticky | ||
| --#{$page}--section--m-sticky-top--ZIndex: var(--pf-t--global--z-index--md); | ||
| --#{$page}--section--m-sticky-top--BoxShadow: var(--pf-t--global--box-shadow--sm--bottom); | ||
|
|
@@ -118,6 +124,7 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| --#{$page}__main-tabs--PaddingBlockStart: 0; | ||
| --#{$page}__main-tabs--PaddingInlineEnd: 0; | ||
| --#{$page}__main-tabs--PaddingBlockEnd: 0; | ||
| --#{$page}__main-tabs--PaddingInlineStart: 0; | ||
| --#{$page}__main-tabs--BackgroundColor: var(--pf-t--global--background--color--primary--default); | ||
|
|
||
| // Wizard main section | ||
|
|
@@ -247,7 +254,6 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| &.pf-m-limit-width { | ||
| display: flex; | ||
| flex-direction: column; | ||
|
There was a problem hiding this comment. Since body is required now, wdyt about moving these styles to this block so all of the main-[whatever] sections (anything that has |
||
|
|
||
| > .#{$page}__main-body { | ||
| flex: 1; | ||
|
There was a problem hiding this comment. I wonder if we can remove this? It's causing this issue of the parent section fills the available space, the 
|
||
|
|
@@ -345,6 +351,7 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| .#{$page}__main-list { | ||
| display: flex; | ||
| flex-direction: column; | ||
| flex-grow: 1; | ||
| } | ||
|
Comment on lines
343
to
347
There was a problem hiding this comment. I think we can take this out now? I only see it in the hackathon demo code. |
||
|
|
||
| .#{$page}__main-nav { | ||
|
|
@@ -429,10 +436,13 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| } | ||
|
|
||
| .#{$page}__main-section { | ||
| display: flex; | ||
| flex-direction: column; | ||
|
There was a problem hiding this comment. I think you can remove this since you added it here patternfly/src/patternfly/components/Page/page.scss Lines 263 to 272 in bab3e8a |
||
| gap: var(--#{$page}__main-section--RowGap); | ||
| padding-block-start: var(--#{$page}__main-section--PaddingBlockStart); | ||
| padding-block-end: var(--#{$page}__main-section--PaddingBlockEnd); | ||
| padding-inline-start: calc(var(--#{$page}__main-section--PaddingInlineStart) - var(--#{$page}__main-container--BorderWidth)); | ||
| padding-inline-end: calc(var(--#{$page}__main-section--PaddingInlineEnd) - var(--#{$page}__main-container--BorderWidth)); | ||
| background-color: var(--#{$page}__main-section--BackgroundColor); | ||
|
|
||
| &.pf-m-secondary { | ||
|
|
@@ -447,17 +457,17 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| &.pf-m-padding#{$breakpoint-name} { | ||
| padding-block-start: var(--#{$page}__main-section--PaddingBlockStart); | ||
| padding-block-end: var(--#{$page}__main-section--PaddingBlockEnd); | ||
| padding-inline-start: calc(var(--#{$page}__main-section--PaddingInlineStart) - var(--#{$page}__main-container--BorderWidth)); | ||
| padding-inline-end: calc(var(--#{$page}__main-section--PaddingInlineEnd) - var(--#{$page}__main-container--BorderWidth)); | ||
|
|
||
| &.pf-m-limit-width { | ||
| padding: 0; | ||
|
|
||
| .#{$page}__main-body { | ||
| padding-block-start: var(--#{$page}__main-section--PaddingBlockStart); | ||
| padding-block-end: var(--#{$page}__main-section--PaddingBlockEnd); | ||
| padding-inline-start: calc(var(--#{$page}__main-section--PaddingInlineStart) - var(--#{$page}__main-container--BorderWidth)); | ||
| padding-inline-end: calc(var(--#{$page}__main-section--PaddingInlineEnd) - var(--#{$page}__main-container--BorderWidth)); | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -494,28 +504,23 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
|
|
||
| .#{$page}__main-body { | ||
| .#{$page}__main-nav & { | ||
| padding-inline-start: var(--#{$page}__main-nav--PaddingInlineStart); | ||
| padding-inline-end: var(--#{$page}__main-nav--PaddingInlineEnd); | ||
|
Comment on lines
496
to
498
There was a problem hiding this comment. pretty sure you can remove this, it was for tertiary nav, which we removed since it was replaced with horizontal subnav, and we use |
||
| } | ||
|
|
||
| .#{$page}__main-breadcrumb & { | ||
| padding-inline-start: 0; | ||
| padding-inline-end: 0; | ||
| } | ||
|
|
||
| .#{$page}__main-section & { | ||
| padding-inline-start: var(--#{$page}__main-body--PaddingInlineStart); | ||
| padding-inline-end: var(--#{$page}__main-body--PaddingInlineEnd); | ||
| margin-block-start: var(--#{$page}__main-body--MarginBlockStart); | ||
| margin-block-end: var(--#{$page}__main-body--MarginBlockEnd); | ||
| } | ||
|
|
||
| .#{$page}__main-tabs & { | ||
| padding-inline-start: var(--#{$page}__main-tabs--PaddingInlineStart); | ||
| padding-inline-end: var(--#{$page}__main-tabs--PaddingInlineEnd); | ||
| } | ||
|
|
@@ -528,4 +533,3 @@ $pf-page-v6--height-breakpoint-map: build-breakpoint-map("base", "sm", "md", "lg | |
| flex: 1 0 auto; | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 love the update to hold the actual spacer here. Much better for customization.