Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tabs): Introduce Tabs component #868

Merged
merged 60 commits into from Nov 15, 2018

Commits on Nov 12, 2018

  1. Configuration menu
    Copy the full SHA
    cee6b91 View commit details
    Browse the repository at this point in the history
  2. Fixed active color and border color

    Border color wasn’t using a global variable, and the active tab color wasn’t meeting accessibility requirements.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    4d5e941 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0aa5c56 View commit details
    Browse the repository at this point in the history
  4. Fixed bottom border of active tabs with secondary

    The bottom border of the active tab would stay visible whenever secondary tabs were present. This commit elevates the active tab’s z-index to make sure that its new bottom border overlaps the secondary’s appropriately, making them look connected.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    b1d705d View commit details
    Browse the repository at this point in the history
  5. Updated variables

    Scroll button padding variables weren’t being used. The buttons are the same height as the tab container and a width variable is implemented instead.
    
    Border width is now controlled by a variable.
    
    Border color of scroll buttons is now set to its own variable.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    13b2918 View commit details
    Browse the repository at this point in the history
  6. Fix active tab overlapping scroll buttons

    Adds a z-index to the scroll buttons to make sure the active tab does not overlap when scrolled below them.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    ee9460f View commit details
    Browse the repository at this point in the history
  7. Changed button modifiers: pf-m-start and pf-m-end

    To align with logical rather than physical values.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    b3abd59 View commit details
    Browse the repository at this point in the history
  8. Add pf-m-start-current modifier

    If a current tab scrolls past a scroll button, the scroll button should be given a similar visual treatment to indicate that the current tab is “over there”. This is done with an additional modifier on .pf-c-tabs.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    a5155ee View commit details
    Browse the repository at this point in the history
  9. Design review updates

    Border color changed. Hover state border/box-shadow changed. Secondary tab hover color changed. Scroll buttons now include the same hover state.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    6f2b6d5 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    6e6ec07 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    22a1317 View commit details
    Browse the repository at this point in the history
  12. Removed role attributes

    Until we figure out a keyboard focus management strategy.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    7c36d25 View commit details
    Browse the repository at this point in the history
  13. Removed custom focus states

    Sticking with browser defaults until we implement our own system-wide focus state in the future.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    1fe875f View commit details
    Browse the repository at this point in the history
  14. Fixed scroll button bg color variable

    This new background color should theoretically change based on the theme.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    5234a6e View commit details
    Browse the repository at this point in the history
  15. Add hidden attribute to non-visible scroll buttons

    To ensure that they aren’t read by screen readers.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    d1fde88 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    9077938 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    4afde97 View commit details
    Browse the repository at this point in the history
  18. BoxShadow variable tweaks

    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    cc204ab View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    9a69f6b View commit details
    Browse the repository at this point in the history
  20. First tab is now the current tab in all examples

    The first tab being active/current is the more typical default case.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    70f8d20 View commit details
    Browse the repository at this point in the history
  21. Added tabs-section.hbs

    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    21438ce View commit details
    Browse the repository at this point in the history
  22. Updated handlebars indentation

    To be consistent with other components.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    9d66084 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    1450cb7 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    0791894 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    5762393 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    85aa280 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    122e3be View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    e50b440 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    e4f4a56 View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    3c75c3c View commit details
    Browse the repository at this point in the history
  31. Updated example titles

    Clarified that the primary tabs example includes sections.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    db9c770 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    6768c6b View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    f26fb3c View commit details
    Browse the repository at this point in the history
  34. Configuration menu
    Copy the full SHA
    7ddd8b2 View commit details
    Browse the repository at this point in the history
  35. Z index tweaks

    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    124d4a0 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    b5f640d View commit details
    Browse the repository at this point in the history
  37. Update current variable name

    Needs a -m because it’s a modifier class.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    8e35819 View commit details
    Browse the repository at this point in the history
  38. Removed global variable from box shadow color

    The new variable is close enough.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    eecdd0f View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    6f77bf1 View commit details
    Browse the repository at this point in the history
  40. Added tabs-button.hbs and aria-controls

    Also moved the ID to the the button element itself rather than the li parent.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    db1b15f View commit details
    Browse the repository at this point in the history
  41. Configuration menu
    Copy the full SHA
    1eb7a37 View commit details
    Browse the repository at this point in the history
  42. Added tabs-list.hbs

    And updated every example to make use of it.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    4d65727 View commit details
    Browse the repository at this point in the history
  43. Replace box-shadows with fancy borders

    Box-shadow doesn’t appear in Windows’ high contrast mode, so this switches Tabs to use borders on ::before and ::after pseudo elements to achieve the same result.
    
    This change required significant restructuring of the SCSS file.
    andybraren committed Nov 12, 2018
    Configuration menu
    Copy the full SHA
    87d9e6e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. Switched to hiding scroll buttons solely via CSS

    Setting display: none; and visibility: hidden; has proven to be an effective way to hide scroll buttons from screen readers, so the hidden attribute is no longer necessary.
    andybraren committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    9883512 View commit details
    Browse the repository at this point in the history
  2. Updated documentation

    Removed outdated parts, updated accessibility and usage sections to reflect the latest structure.
    andybraren committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    1a30741 View commit details
    Browse the repository at this point in the history
  3. Removed unneeded flex

    andybraren committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    b620c82 View commit details
    Browse the repository at this point in the history
  4. Fixed filled style

    Forgot to move the modifier, and adjusted the CSS
    andybraren committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    5e726a8 View commit details
    Browse the repository at this point in the history
  5. Added newline to two docs

    andybraren committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    1ed743b View commit details
    Browse the repository at this point in the history
  6. Removed aria-controls from non-primary examples

    Since we’re keeping sections to the primary example only, including aria-controls in other examples without corresponding sections was invalid.
    andybraren committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    5f15dc8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1af7cde View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4256c78 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    dd669c9 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2018

  1. Configuration menu
    Copy the full SHA
    87579b0 View commit details
    Browse the repository at this point in the history
  2. Updated primary tabs docs

    andybraren committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    834db89 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0e4084b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bf43bf0 View commit details
    Browse the repository at this point in the history
  5. Updated flex implementation

    To keep primary and secondary tabs consistent, primary tabs now use flex rather than inline-flex as well. Also removed some redundant declarations.
    andybraren committed Nov 14, 2018
    Configuration menu
    Copy the full SHA
    a945c54 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2018

  1. Configuration menu
    Copy the full SHA
    7785fb5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b47ec47 View commit details
    Browse the repository at this point in the history
  3. Made secondary tab selector more robust

    Just in case the secondary tabs themselves are not directly adjacent to the primary, they can be contained so long as the modifier is present.
    andybraren committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    39e1586 View commit details
    Browse the repository at this point in the history