New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tabs): Introduce Tabs component #868
Commits on Nov 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for cee6b91 - Browse repository at this point
Copy the full SHA cee6b91View commit details -
Fixed active color and border color
Border color wasn’t using a global variable, and the active tab color wasn’t meeting accessibility requirements.
Configuration menu - View commit details
-
Copy full SHA for 4d5e941 - Browse repository at this point
Copy the full SHA 4d5e941View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0aa5c56 - Browse repository at this point
Copy the full SHA 0aa5c56View commit details -
Fixed bottom border of active tabs with secondary
The bottom border of the active tab would stay visible whenever secondary tabs were present. This commit elevates the active tab’s z-index to make sure that its new bottom border overlaps the secondary’s appropriately, making them look connected.
Configuration menu - View commit details
-
Copy full SHA for b1d705d - Browse repository at this point
Copy the full SHA b1d705dView commit details -
Scroll button padding variables weren’t being used. The buttons are the same height as the tab container and a width variable is implemented instead. Border width is now controlled by a variable. Border color of scroll buttons is now set to its own variable.
Configuration menu - View commit details
-
Copy full SHA for 13b2918 - Browse repository at this point
Copy the full SHA 13b2918View commit details -
Fix active tab overlapping scroll buttons
Adds a z-index to the scroll buttons to make sure the active tab does not overlap when scrolled below them.
Configuration menu - View commit details
-
Copy full SHA for ee9460f - Browse repository at this point
Copy the full SHA ee9460fView commit details -
Changed button modifiers: pf-m-start and pf-m-end
To align with logical rather than physical values.
Configuration menu - View commit details
-
Copy full SHA for b3abd59 - Browse repository at this point
Copy the full SHA b3abd59View commit details -
Add pf-m-start-current modifier
If a current tab scrolls past a scroll button, the scroll button should be given a similar visual treatment to indicate that the current tab is “over there”. This is done with an additional modifier on .pf-c-tabs.
Configuration menu - View commit details
-
Copy full SHA for a5155ee - Browse repository at this point
Copy the full SHA a5155eeView commit details -
Border color changed. Hover state border/box-shadow changed. Secondary tab hover color changed. Scroll buttons now include the same hover state.
Configuration menu - View commit details
-
Copy full SHA for 6f2b6d5 - Browse repository at this point
Copy the full SHA 6f2b6d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e6ec07 - Browse repository at this point
Copy the full SHA 6e6ec07View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22a1317 - Browse repository at this point
Copy the full SHA 22a1317View commit details -
Until we figure out a keyboard focus management strategy.
Configuration menu - View commit details
-
Copy full SHA for 7c36d25 - Browse repository at this point
Copy the full SHA 7c36d25View commit details -
Sticking with browser defaults until we implement our own system-wide focus state in the future.
Configuration menu - View commit details
-
Copy full SHA for 1fe875f - Browse repository at this point
Copy the full SHA 1fe875fView commit details -
Fixed scroll button bg color variable
This new background color should theoretically change based on the theme.
Configuration menu - View commit details
-
Copy full SHA for 5234a6e - Browse repository at this point
Copy the full SHA 5234a6eView commit details -
Add hidden attribute to non-visible scroll buttons
To ensure that they aren’t read by screen readers.
Configuration menu - View commit details
-
Copy full SHA for d1fde88 - Browse repository at this point
Copy the full SHA d1fde88View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9077938 - Browse repository at this point
Copy the full SHA 9077938View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4afde97 - Browse repository at this point
Copy the full SHA 4afde97View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc204ab - Browse repository at this point
Copy the full SHA cc204abView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a69f6b - Browse repository at this point
Copy the full SHA 9a69f6bView commit details -
First tab is now the current tab in all examples
The first tab being active/current is the more typical default case.
Configuration menu - View commit details
-
Copy full SHA for 70f8d20 - Browse repository at this point
Copy the full SHA 70f8d20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21438ce - Browse repository at this point
Copy the full SHA 21438ceView commit details -
Updated handlebars indentation
To be consistent with other components.
Configuration menu - View commit details
-
Copy full SHA for 9d66084 - Browse repository at this point
Copy the full SHA 9d66084View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1450cb7 - Browse repository at this point
Copy the full SHA 1450cb7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0791894 - Browse repository at this point
Copy the full SHA 0791894View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5762393 - Browse repository at this point
Copy the full SHA 5762393View commit details -
Configuration menu - View commit details
-
Copy full SHA for 85aa280 - Browse repository at this point
Copy the full SHA 85aa280View commit details -
Configuration menu - View commit details
-
Copy full SHA for 122e3be - Browse repository at this point
Copy the full SHA 122e3beView commit details -
Configuration menu - View commit details
-
Copy full SHA for e50b440 - Browse repository at this point
Copy the full SHA e50b440View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4f4a56 - Browse repository at this point
Copy the full SHA e4f4a56View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c75c3c - Browse repository at this point
Copy the full SHA 3c75c3cView commit details -
Clarified that the primary tabs example includes sections.
Configuration menu - View commit details
-
Copy full SHA for db9c770 - Browse repository at this point
Copy the full SHA db9c770View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6768c6b - Browse repository at this point
Copy the full SHA 6768c6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f26fb3c - Browse repository at this point
Copy the full SHA f26fb3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ddd8b2 - Browse repository at this point
Copy the full SHA 7ddd8b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 124d4a0 - Browse repository at this point
Copy the full SHA 124d4a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5f640d - Browse repository at this point
Copy the full SHA b5f640dView commit details -
Needs a -m because it’s a modifier class.
Configuration menu - View commit details
-
Copy full SHA for 8e35819 - Browse repository at this point
Copy the full SHA 8e35819View commit details -
Removed global variable from box shadow color
The new variable is close enough.
Configuration menu - View commit details
-
Copy full SHA for eecdd0f - Browse repository at this point
Copy the full SHA eecdd0fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f77bf1 - Browse repository at this point
Copy the full SHA 6f77bf1View commit details -
Added tabs-button.hbs and aria-controls
Also moved the ID to the the button element itself rather than the li parent.
Configuration menu - View commit details
-
Copy full SHA for db1b15f - Browse repository at this point
Copy the full SHA db1b15fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1eb7a37 - Browse repository at this point
Copy the full SHA 1eb7a37View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d65727 - Browse repository at this point
Copy the full SHA 4d65727View commit details -
Replace box-shadows with fancy borders
Box-shadow doesn’t appear in Windows’ high contrast mode, so this switches Tabs to use borders on ::before and ::after pseudo elements to achieve the same result. This change required significant restructuring of the SCSS file.
Configuration menu - View commit details
-
Copy full SHA for 87d9e6e - Browse repository at this point
Copy the full SHA 87d9e6eView commit details
Commits on Nov 13, 2018
-
Switched to hiding scroll buttons solely via CSS
Setting display: none; and visibility: hidden; has proven to be an effective way to hide scroll buttons from screen readers, so the hidden attribute is no longer necessary.
Configuration menu - View commit details
-
Copy full SHA for 9883512 - Browse repository at this point
Copy the full SHA 9883512View commit details -
Removed outdated parts, updated accessibility and usage sections to reflect the latest structure.
Configuration menu - View commit details
-
Copy full SHA for 1a30741 - Browse repository at this point
Copy the full SHA 1a30741View commit details -
Configuration menu - View commit details
-
Copy full SHA for b620c82 - Browse repository at this point
Copy the full SHA b620c82View commit details -
Forgot to move the modifier, and adjusted the CSS
Configuration menu - View commit details
-
Copy full SHA for 5e726a8 - Browse repository at this point
Copy the full SHA 5e726a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ed743b - Browse repository at this point
Copy the full SHA 1ed743bView commit details -
Removed aria-controls from non-primary examples
Since we’re keeping sections to the primary example only, including aria-controls in other examples without corresponding sections was invalid.
Configuration menu - View commit details
-
Copy full SHA for 5f15dc8 - Browse repository at this point
Copy the full SHA 5f15dc8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1af7cde - Browse repository at this point
Copy the full SHA 1af7cdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4256c78 - Browse repository at this point
Copy the full SHA 4256c78View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd669c9 - Browse repository at this point
Copy the full SHA dd669c9View commit details
Commits on Nov 14, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 87579b0 - Browse repository at this point
Copy the full SHA 87579b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 834db89 - Browse repository at this point
Copy the full SHA 834db89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e4084b - Browse repository at this point
Copy the full SHA 0e4084bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bf43bf0 - Browse repository at this point
Copy the full SHA bf43bf0View commit details -
To keep primary and secondary tabs consistent, primary tabs now use flex rather than inline-flex as well. Also removed some redundant declarations.
Configuration menu - View commit details
-
Copy full SHA for a945c54 - Browse repository at this point
Copy the full SHA a945c54View commit details
Commits on Nov 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 7785fb5 - Browse repository at this point
Copy the full SHA 7785fb5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b47ec47 - Browse repository at this point
Copy the full SHA b47ec47View commit details -
Made secondary tab selector more robust
Just in case the secondary tabs themselves are not directly adjacent to the primary, they can be contained so long as the modifier is present.
Configuration menu - View commit details
-
Copy full SHA for 39e1586 - Browse repository at this point
Copy the full SHA 39e1586View commit details