Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logic for showing, scaling or hiding the tag on an edge depending on the details level of the graph #123

Merged
merged 3 commits into from
Dec 13, 2023

Conversation

leandroberetta
Copy link
Collaborator

@leandroberetta leandroberetta commented Dec 1, 2023

Resolves #122.

When hovering on details level != high:

image

@jeff-phillips-18
Copy link
Member

Changes look good. I did notice the nodes are not hiding details at low scales as they should be. Added issue #124

Co-authored-by: Jeff Phillips <jephilli@redhat.com>
Co-authored-by: Jeff Phillips <jephilli@redhat.com>
@leandroberetta
Copy link
Collaborator Author

Changes look good. I did notice the nodes are not hiding details at low scales as they should be. Added issue #124

Thanks @jeff-phillips-18. I will take a look to the nodes issue too.

Copy link
Collaborator

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit bf94564 into patternfly:main Dec 13, 2023
7 checks passed
Copy link

🎉 This PR is included in version 5.2.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide tags when details level is low, except when hovering on the edge
3 participants