Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .ask() method to Elasticsearch vector search class #358

Closed
andreibondarev opened this issue Oct 18, 2023 · 2 comments
Closed

Add .ask() method to Elasticsearch vector search class #358

andreibondarev opened this issue Oct 18, 2023 · 2 comments

Comments

@andreibondarev
Copy link
Collaborator

https://github.com/andreibondarev/langchainrb/blob/main/lib/langchain/vectorsearch/elasticsearch.rb#L119-L121
@andreibondarev
Copy link
Collaborator Author

^^ @sivagollapalli Thank you!

sivagollapalli added a commit to sivagollapalli/langchainrb that referenced this issue Oct 29, 2023
@sivagollapalli
[patterns-ai-core#358] [WIP] Added ask functionality
d6f4d7d
andreibondarev added a commit that referenced this issue Nov 15, 2023
@sivagollapalli @andreibondarev
[#358] Added ask functionality (#374)
8c978c0 
* [#358] [WIP] Added ask functionality

* Added specs for ES ask

* FIX# Rubocop issues

---------

Co-authored-by: Andrei Bondarev <andrei@sourcelabs.io>
@sivagollapalli
Copy link
Contributor

@andreibondarev I think we can close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sivagollapalli @andreibondarev