Add k to pinecone's "ask" functionality #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -141,7 +141,7 @@ def similarity_search_by_vector(embedding:, k: 4, namespace: "", filter: nil) | |||
| # @param filter [String] The filter to use | |||
| # @yield [String] Stream responses back one String at a time | |||
| # @return [String] The answer to the question | |||
| def ask(question:, namespace: "", filter: nil, &block) | |||
| def ask(question:, namespace: "", filter: nil, k: 4, &block) | |||
| search_results = similarity_search(query: question, namespace: namespace, filter: filter) | |||
There was a problem hiding this comment.
I think you meant to also pass the k: param to the similarity_search(..., k: k)?
There was a problem hiding this comment.
🤦 yes - absolutely did mean to do that. long day sorry.
andreibondarev
approved these changes
Aug 21, 2023
|
@asmorris I wouldn't be opposed to adding the same param to all other vector search DBs if you feel like coding it up! |
I can absolutely do that! Great idea |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running into an issue when asking a question of OpenAI using pinecone, where there were occasions where the context provided by the
askmethod was over the 4096 tokens, and so was exceeding the default OpenAI context window for question asking. This change would allow a user to add in an additional parameterkto the ask method, which could be subsequently passed tosimilarity_searchto allow the user to have the amount of relevant results they wish, instead of defaulting to the 4 that is withsimilarity_searchcurrently.