Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the use of OpenAI's rough token count #469

Closed
wants to merge 3 commits into from

Conversation

Sergio-e
Copy link

Context

Noticed that the tiktoken_ruby dependency isn't thread-safe. For us, this resulted in the Sidekiq process crashing consistently. There is also an open issue regarding this problem

Proposal

Allow the use of OpenAI's rough token count instead of using tiktoken ruby. The token count selection will be made when initializing the LLM:

    Langchain::LLM::OpenAI.new(
      api_key: openai_access_token,
      llm_options: {},
      default_options: { token_counter: :openai }
    )

tiktoken_ruby will be left as the default option.

@andreibondarev
Copy link
Collaborator

@Sergio-e Do we still need this? I got rid of the automatic max_tokens validation via tiktoken. I think that feature was more annoying than helpful.

@Sergio-e
Copy link
Author

@Sergio-e Do we still need this? I got rid of the automatic max_tokens validation via tiktoken. I think that feature was more annoying than helpful.

It seems not. The issue is now fixed on the latest Tiktoken ruby release

@Sergio-e Sergio-e closed this Jun 10, 2024
@Sergio-e Sergio-e deleted the rough_token_count branch June 10, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants