Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax faraday dep #3

Merged
merged 3 commits into from
May 10, 2023
Merged

Relax faraday dep #3

merged 3 commits into from
May 10, 2023

Conversation

andreibondarev
Copy link
Collaborator

No description provided.

@andreibondarev andreibondarev merged commit d6bb060 into master May 10, 2023
2 of 4 checks passed
@andreibondarev andreibondarev deleted the relax-faraday-dep branch May 10, 2023 15:43
@@ -35,6 +35,7 @@ Gem::Specification.new do |spec|
# For more information and examples about making a new gem, check out our
# guide at: https://bundler.io/guides/creating_gem.html

spec.add_dependency "faraday", "~> 2.7"
spec.add_dependency "faraday", "~> 1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like adding faraday_middleware may prevent installing faraday 2.0.1 or higher.

Is there a reason this gem needs to keep support for versions less than 2.0? Could we use ~> 2.0.1 and drop faraday_middleware as a dependency?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think the move is to bump it to faraday >2 everywhere. When I say "everywhere" I mean all of the other gems also required by langchainrb.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some are already allowing for 2.0.1 and higher:

  • replicate-ruby: ">= 1.0"
  • hugging-face: ">= 1.0"
  • anthropic: ">= 1"
  • ruby-openai: ">= 1"

This one had an outstanding pull request already:

Created MRs for these:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rthbound I've released new versions for all of these gems. Would you like to try bumping up the dependencies on Langchain.rb?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll still need to wait for the open-weather-ruby-client gem to merge before we can update Langchain.rb's gemspec to specify the latest versions of these gems. If we update sooner, then bundle install won't run successfully within the langchain project.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rthbound Looks like we're all set!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rthbound I went ahead and bumped the gems versions: patterns-ai-core/langchainrb#302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants