Commit
Commit 7e71adc fixes a problem with git-gui failing to pick up the original author identity during a commit --amend operation. However, the new author details then become persistent for the remainder of the session. This commit fixes this by ensuring the environment variables are reset and the author information reset once the commit is completed. The relevant changes were reworked to reduce global variables. Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
- Loading branch information
There are no files selected for viewing
4 comments
on commit cfe616b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
The encoding bug is unresolved though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One bug per feature branch! The encoding one is on another assuming you mean the patches from karsten blees that are on the git-for-windows release. The pu branch contains those + this one. As per the it repository, pu is subject to random rebasing but handy for testing what might end up in master.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sure. I didn't mean to include a fix on this branch.
I don't know what patch you mean. Couldn't find it. I referred to git-for-windows/git#761.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - no. I suspect that is a problem with handling unicode environment variables in Tcl. I've not had any chance to dig into that.
Do you need -nocomplain here?