-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Float datatypes #10
Comments
Could this just be floats being floats? It seems like it may be more of a "how different languages format numbers by default" issue than anything else. |
Yeah, it is just floats being floats. But I just wasn't sure if n5 is used in cases where floating point precision might be an issue. You should always be able to write and read float64 exactly, but should we throw a warning or error if you try to write ints to a float dataset which works, but is imprecise |
That's a good call. Given numpy arrays have strict types which can easily be cast between anyway, I'd throw an error if someone tried to write an int array to a float dataset - make the caller do |
Thats what I was thinking. Its not a huge priority for now, so I'll leave it with expected fail tests. I think this problem should resolve itself when we build in numpy support to the rust side |
Improve testing of float datatypes
Problems with datasets of type float
The text was updated successfully, but these errors were encountered: