Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fallbackFlagInUnkownNanp doesn't seem to work when countriesData is passed #114

Open
brunops opened this issue Apr 26, 2016 · 0 comments
Open

Comments

@brunops
Copy link
Contributor

brunops commented Apr 26, 2016

Hey Patrick, I was finally playing with the fallbackFlagInUnkownNanp option, but it doesn't seem to work.

I noticed 2 issues in the PR:

  1. Minor typo in the description https://github.com/patw0929/react-intl-tel-input/pull/110/files#diff-3ec40a1e2a924ba4ba6521185d17b0f2R229
  2. While debugging, although fallbackFlagInUnkownNanp is set to false, the alreadySelected variable is false as well (as the Puerto Rico example if you remember), so the fallback executes and the same problem happens https://github.com/patw0929/react-intl-tel-input/pull/110/files#diff-8d03d40cef8605ae4608d7284524a5b7R486

here's a cryptic screenshot that might help, the problem might be of how utils.getNumeric work (+1 returns "us", although
screen shot 2016-04-26 at 11 15 42 am

It might be the case that this only happens when this.props.countriesData is passed and hence why your tests possibly worked. Do you think this is the wrong place to initialize the countries? https://github.com/patw0929/react-intl-tel-input/blob/master/src/containers/IntlTelInputApp.js#L608

sorry for opening all these issues :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant