Add preprocessValue callback, just to allow users to change value a…

[brunops]

…s they type

• This is useful to do normalizations, like transforming japanese numbers (e.g., １, ２, etc.) to the right alpha numbers (e.g., 1, 2, etc.).
• I wasn't able to change anything as the component seems to completely manage its own state and it doesn't take defaultValue property.. directly changing value makes the cursor jump like crazy.
• I tried adding a test for this, but Simulate.change and Simulate.keyDown

[coveralls]

Coverage increased (+0.5%) to 92.388% when pulling 3e3ba64 on brunops:preprocess-value into 0d18e74 on patw0929:master.

[janmarek]

directly changing value makes the cursor jump like crazy

I think this is the real issue. IMO normalization should be done by saving fixed value and passing it as value prop.

[brunops]

@janmarek I meant passing value directly makes the cursor jump very weirdly, not only to the end, but very odd behavior, probably because the component is managing its own state internally. Not sure if it's related to the fact that utilsScript already does formatting (cursor already jumps even on demo page, but a "normal jump").

For the use case I mentioned, the preprocessValue part makes the component work as is.

[brunops]

@patw0929 any thoughts on this?

[patw0929]

Hi @brunops
Sorry, I'm busy at my work recently. 😲 😲 😲
Have a not carefully thought here, maybe the "normalization" can be a build-in feature, and handling in TelInput's keydown event?

[brunops]

Oh, no problem man.

I wouldn't add normalization as part of the plugin itself, I think providing a callback where people can process the input any way they want to is more flexible (most people will probably never use this).

[patw0929]

Sorry for being busy so long... 😭

---

I'm curious about the need of normalizations. Because we already restrict the input keys in 0 ~ 9 & + in handleKeyPress function, so users should not have any chance to key in full width numbers like １, ２, right?

[brunops]

@patw0929 no worries man!

You are correct, the problem appears when full width numbers need to be allowed, in a way that instead of when typing １, instead of showing nothing, would actually show 1. Let me know if that's clear

[mcataford]

Going to close this due to age, not opposed to revisiting the underlying changes / ideas though!