Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass down status to onSelectFlag by using isValidNumberForRegion #140

Merged
merged 2 commits into from Aug 29, 2016
Merged

Pass down status to onSelectFlag by using isValidNumberForRegion #140

merged 2 commits into from Aug 29, 2016

Conversation

ghost
Copy link

@ghost ghost commented Aug 26, 2016

It may be useful for onSelectFlag validation by using isValidNumberForRegion util.

@patw0929
Copy link
Owner

patw0929 commented Aug 28, 2016

Thanks for contribution!

However I find out that you install the google-libphonenumber in this PR, that makes the main.js more larger (from 47K to 389K).
Actually the current src/libphonenumber.js we used was copied from intl-tel-input's custom version. It wrapped some custom functions in there.
And if we import google-libphonenumber here, I think it might have some duplicated part.

Any idea to implement the feature in other way? 🤔

@ghost
Copy link
Author

ghost commented Aug 28, 2016

Thanks for answering! I didn't know that you guys just import utils.js from intl-tel-input

Now for sure it would be easier to simplify all this :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.09%) to 94.168% when pulling fd39e98 on viktop:add/status-number-to-onselectflag into 90b32a8 on patw0929:master.

@patw0929 patw0929 merged commit e2bdad5 into patw0929:master Aug 29, 2016
patw0929 added a commit that referenced this pull request Aug 29, 2016
* #140: Pass down status to onSelectFlag by using isValidNumberForRegion
* #141: Added on blur callback handler
* #142: implement state.value change in componentWillReceiveProps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants