Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Prop-types out of peer dependency. remove proptypes in dist. #207

Merged
merged 1 commit into from
Apr 22, 2018

Conversation

dphrag
Copy link
Contributor

@dphrag dphrag commented Apr 21, 2018

Remove proptypes from peer dependency (was throwing warning which brought me here 馃槃 ). As per: facebook/prop-types#44 (comment)

Moved proptypes to dependencies (similar to the style-proptype lib).

Added babel plugin to remove proptypes from dist, as they aren't executed.

main.js 76kb -> 74kb.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.01% when pulling 57a6956 on dphrag:master into 2572680 on patw0929:master.

@patw0929 patw0929 merged commit 8f28438 into patw0929:master Apr 22, 2018
patw0929 added a commit that referenced this pull request Apr 22, 2018
Bug fixes:

* #207: Move Prop-types out of peer dependency. remove proptypes in dist (by @dphrag)
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Move Prop-types out of peer dependency. remove proptypes in dist.
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
Bug fixes:

* patw0929#207: Move Prop-types out of peer dependency. remove proptypes in dist (by @dphrag)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants