Remove Outdated react lifecycle components & updated the react version to 16.4.1 #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patw0929
reviewed
Jul 15, 2018
| } | ||
|
|
||
| componentWillUpdate(nextProps, nextState) { | ||
| shouldComponentUpdate(nextProps, nextState) { | ||
| if (nextState.showDropdown) { |
There was a problem hiding this comment.
Although it's work, but I'm not sure if it is an anti-pattern to put codes which is not related to component-update control. 🤔
There was a problem hiding this comment.
componentWillUpdate is gone.
The only place left for component will update code to go is in should component update
patw0929
approved these changes
Jul 16, 2018
|
Merging it !! |
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
…n to 16.4.1 (patw0929#227) * Bumping React version to 16.4.1 & removing deprecated lifecycle events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@patw0929