Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional onPhoneNumberFocus function #308

Merged
merged 1 commit into from
Oct 20, 2019

Conversation

johannessjoberg
Copy link
Contributor

@johannessjoberg johannessjoberg commented Oct 17, 2019

Added optional onPhoneNumberFocus function, similar to onPhoneNumberBlur.

Description

Added onPhoneNumberFocus because it's not possible to extended onFocus in telInputProps property due to onFocus being overwritten in src/components/TelInput.js. There is an open PR addressing the same thing in #239, but it has been stale for some time and lack tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have used ESLint & Prettier to follow the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 93.656% when pulling 0362b6b on DPOrganizer:feature/on-phone-number-focus into ced4b09 on patw0929:master.

@patw0929
Copy link
Owner

Thanks a lot! Looks great! 🙌
Could you help to update Documentation - Props?

@johannessjoberg
Copy link
Contributor Author

Thanks @patw0929! From what I understood the Props storybook automatically picks things from IntlTelInput.propTypes so it should already be in place ☺️

@patw0929 patw0929 merged commit 66a1a35 into patw0929:master Oct 20, 2019
patw0929 added a commit that referenced this pull request Oct 20, 2019
New features

- #308: Add optional onPhoneNumberFocus function (by @johannessjoberg)
@patw0929
Copy link
Owner

You're right! I forgot it 😅
Thank you!
Merged & released as v7.1.0.

@johannessjoberg
Copy link
Contributor Author

Thanks @patw0929 for the fast response and feedback! Great lib! 👍

andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
…ber-focus

Add optional onPhoneNumberFocus function
andrewsantarin pushed a commit to andrewsantarin/react-intl-tel-input that referenced this pull request Feb 2, 2022
New features

- patw0929#308: Add optional onPhoneNumberFocus function (by @johannessjoberg)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants