Bug fix: Bypass formatNumber if user is deleting #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Thank you so much! ❤️ |
|
Published as v7.1.1. |
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
Bug fix: Bypass formatNumber if user is deleting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.loom.com/share/a4d1e5295b0341ecb3da4a2c019e32b4
Description
** Pls see the video. This PR potentially fixes the following bug:
For some localities (I've only identified Russia), when a user deletes numbers
window.intlTelInputUtils.formatNumberbehaves incorrectly.window.intlTelInputUtils.formatNumber('8 (444) 444-44-4', 'ru', 2) ==> "8 (844) 444-44-44"
window.intlTelInputUtils.formatNumber('8 (844) 444-44-4', 'ru', 2) ==> "8 (884) 444-44-44"
window.intlTelInputUtils.formatNumber('8 (884) 444-44-4', 'ru', 2) ==> "8 (888) 444-44-44"
window.intlTelInputUtils.formatNumber('8 (888) 44-44-4', 'ru', 2) ==> "8 (888) 844-44-44"
window.intlTelInputUtils.formatNumber('8 (888) 84-44-4', 'ru', 2) ==> "8 (888) 884-44-44"
. . . and so on, until all digits are '8'.
Screenshots (if appropriate):
See video above
Types of changes
Adds a check on IntlTelInput -> If user has deleted from input val, do not perform a format.
Checklist: