Extract constants and purge superfluous utils #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 8.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
andrewsantarin
pushed a commit
to andrewsantarin/react-intl-tel-input
that referenced
this pull request
Feb 2, 2022
* refactor: booleans are eq * refactor: extract constants * refactor: addClass can be replaced by classList.add * refactor: unused util
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preamble
These are some more cleaning changes that reduce redundancy and work towards separating concerns in the codebase. Since
classListhas been well-supported and the utils included in the utility file were more than 10 years old now, I purged them in favour of the more directclassList'saddandremove.Types of changes
Checklist:
[ ] I have updated the documentation accordingly.[ ] I have added tests to cover my changes.