Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the Twitter Hashtag #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed the Twitter Hashtag #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5bbaa6
Changed the twitter hashtag
Apr 27, 2023
c511238
Do not unwrap values brutally
Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: e13e13db912b10785acb747759cad7c4c40d5d72

COCOAPODS: 1.11.3
COCOAPODS: 1.12.1
4 changes: 4 additions & 0 deletions RobotConf/SwiftGen/Strings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ internal enum L10n {
internal static let sponsors = L10n.tr("Localizable", "about.sponsors")
/// About
internal static let tabTitle = L10n.tr("Localizable", "about.tabTitle")
internal enum Social {
/// #AMxDC23
internal static let twitterHashtag = L10n.tr("Localizable", "about.social.twitterHashtag")
}
}

internal enum Agenda {
Expand Down
2 changes: 1 addition & 1 deletion RobotConf/UI/About/AboutView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ struct AboutView: View {
Button(action: {
self.viewModel.openHashtagPage()
}) {
Text("#AndroidMakers")
Text(L10n.About.Social.twitterHashtag)
.foregroundColor(Color(Asset.Colors.link.color))
}
HStack(spacing: 16) {
Expand Down
4 changes: 3 additions & 1 deletion RobotConf/UI/About/AboutViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@ class AboutViewModel: ObservableObject, Identifiable {
}

func openHashtagPage() {
let screenName = "AndroidMakers"
let screenName = L10n.About.Social.twitterHashtag
.addingPercentEncoding(withAllowedCharacters: .urlPathAllowed) ?? ""

let appURL = URL(string: "twitter://search?query=\(screenName)")!
let webURL = URL(string: "https://twitter.com/search?q=\(screenName)")!

Expand Down
1 change: 1 addition & 0 deletions RobotConf/UI/Resources/en.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ All the talks will be recorded, and uploaded on the Youtube channel.";
"about.coc" = "Code of conduct";
"about.social" = "Social";
"about.sponsors" = "Sponsors";
"about.social.twitterHashtag" = "#AMxDC23";

"talk.complexity.beginner" = "Beginner";
"talk.complexity.intermediate" = "Intermediate";
Expand Down
1 change: 1 addition & 0 deletions RobotConf/UI/Resources/fr.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ Tous les talks seront enregistrées, et mis sur la chaîne YouTube.";
"about.coc" = "Code de conduite";
"about.social" = "Social";
"about.sponsors" = "Sponsors";
"about.social.twitterHashtag" = "#AMxDC23";

"talk.complexity.beginner" = "Débutant";
"talk.complexity.intermediate" = "Intermédiaire";
Expand Down