Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch speaker list from the network #239

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Fetch speaker list from the network #239

merged 2 commits into from
Apr 5, 2024

Conversation

BoD
Copy link
Collaborator

@BoD BoD commented Apr 4, 2024

It was fetched from the cache first

endpointUrl.set("https://androidmakers-2023.ew.r.appspot.com/graphql")
endpointUrl.set("https://confetti-app.dev/graphql")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@@ -51,7 +51,8 @@ apollo {

introspection {
schemaFile.set(file("src/commonMain/graphql/schema.graphqls"))
endpointUrl.set("https://androidmakers-2023.ew.r.appspot.com/graphql")
endpointUrl.set("https://confetti-app.dev/graphql")
headers.set(mapOf("conference" to "androidmakers2024"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required for introspection? I would hope the schema does not depend on the conference

Copy link
Collaborator Author

@BoD BoD Apr 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No but the IJ plugin also looks at these headers and inject them when running queries from the UI :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Well this is a bit surprising. Might adding a comment?

@martinbonnin martinbonnin merged commit 745522a into main Apr 5, 2024
1 check passed
@martinbonnin martinbonnin deleted the fix-no-speakers branch April 5, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants