Use Stan 2.26 functions

[hsbadr]

Now that the development version of rstan supports Stan version 2.26, it may be more efficient to use the new functions, such as log_inv_logit_diff:

brms/R/stan-response.R

Line 528 in 6c604e1

# TODO: replace with log_inv_logit_diff once rstan >= 2.25

Also, since version 2.25 won't exist, as mentioned by @rok-cesnovar in #1074 (comment), it'd be cleaner to use version 2.26.

[paul-buerkner]

We will need to wait until that rstan version is on CRAN. Hamada S. Badr <notifications@github.com> schrieb am Di., 26. Jan. 2021, 23:55:

…

Now that the development version of rstan supports Stan version 2.26, it may be more efficient to use the new functions, such as log_inv_logit_diff : https://github.com/paul-buerkner/brms/blob/6c604e194952da7311b28ebb8bac00c7958806bc/R/stan-response.R#L528 Also, since version 2.25 won't exist, as mentioned by @rok-cesnovar <https://github.com/rok-cesnovar> in #1074 (comment) <#1074 (comment)>, it'd be cleaner to use version 2.26. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1077>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCW2AB246Z7ZM3INIYNSZTS35B5PANCNFSM4WUH5XPA> .

[hsbadr]

We will need to wait until that rstan version is on CRAN.

Yes, just preparing for it. I'll open a PR and leave it until the new version is published on CRAN.

[hsbadr]

We will need to wait until that rstan version is on CRAN.

@paul-buerkner Please help in replacing the functions in #1078. We can still make this conditional:

if (rstan::stan_version() >= 2.26) {
  # Use the new functions
} else {
  # Keep the current code.
}

[paul-buerkner]

I am sorry but I have so much stuff on my hands right now that won't be able to do much on this at the moment. But I will come back to it when I can. Thank you for opening this issue and taking the first steps. Hamada S. Badr <notifications@github.com> schrieb am Mi., 27. Jan. 2021, 00:08:

…

We will need to wait until that rstan version is on CRAN. @paul-buerkner <https://github.com/paul-buerkner> Please help in replacing the functions in #1078 <#1078>. We can still make this conditional: if (rstan::stan_version() >= 2.26) { # Use the new functions } else { # Keep the current code. } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1077 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADCW2AAK2VAM4JYNAMSOSIDS35DQTANCNFSM4WUH5XPA> .

[hsbadr]

I am sorry but I have so much stuff on my hands right now that won't be able to do much on this at the moment. But I will come back to it when I can.

No problem. Take your time! None of this is urgent. The performance may or may not change, but it'd be great to follow the Stan development anyway.

[paul-buerkner]

Most of this is now implemented. Only categorical_logit_glm is missing, but that will be added too for the 2.21 release.

[paul-buerkner]

Completed now.