Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Amend #1459 #1460

Merged
merged 2 commits into from Feb 15, 2023
Merged

Amend #1459 #1460

merged 2 commits into from Feb 15, 2023

Conversation

fweber144
Copy link
Contributor

This is an amendment for #1459. I realized that check_response = TRUE has no effect if req_vars = character(), so we need to set req_vars to the response variable.

@fweber144
Amend paul-buerkner#1459: check_response = TRUE has no effect if `r…
44f4283 
…eq_vars = character()`

Thus, we need to set `req_vars` to the response variable.
@fweber144
Update NEWS.md.
11279ca
@paul-buerkner paul-buerkner merged commit d83de47 into paul-buerkner:master Feb 15, 2023
@fweber144 fweber144 deleted the fix1459 branch February 16, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fweber144 @paul-buerkner