Merge pull request #50 from paul-florentin-charles/dev

Dev
paul-florentin-charles · Nov 29, 2023 · aa823e4 · aa823e4
2 parents 3a57a30 + 40e1a76
commit aa823e4
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/api/error_wrappers.py b/src/api/error_wrappers.py
@@ -18,6 +18,6 @@ def bad_request(message: str) -> Response:
     """
 
     return make_response(
-        ApiError().dump({"name": HTTPStatus.BAD_REQUEST.phrase, "message": message}),
+        ApiError().dump({"message": message}),
         HTTPStatus.BAD_REQUEST.value,
     )
diff --git a/src/api/schemas.py b/src/api/schemas.py
@@ -54,6 +54,10 @@ class YearsAboveOrBelowNormalSchema(BaseSchema):
 
 
 class ApiError(Schema):
+    """
+    Generic schema to depict any error.
+    """
+
     code: int = fields.Int(dump_default=HTTPStatus.BAD_REQUEST.value)
-    name: str = fields.Str()
+    name: str = fields.Str(dump_default=HTTPStatus.BAD_REQUEST.phrase)
     message: str = fields.Str()
diff --git a/tst/core/utils/enums/test_time_modes.py b/tst/core/utils/enums/test_time_modes.py
@@ -4,5 +4,5 @@
 def test_time_modes() -> None:
     assert len(TimeMode) == 3
 
-    for time_mode in TimeMode:
-        assert isinstance(time_mode.value, str)
+    for t_mode in TimeMode.values():
+        assert isinstance(t_mode, str)