Merge branch 'master' of https://github.com/olarotseyi/nodejs-currenc…

…y-converter into pr/34
paul-shuvo · Nov 4, 2022 · 65d0fff · 65d0fff
2 parents 528f30a + 00fd838
commit 65d0fff
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/index.js b/index.js
@@ -333,6 +333,12 @@ class CurrencyConverter {
   }
 
   addRateToRatesCache(currencyPair, rate_) {
+    if (typeof currencyPair != "string")
+      throw new TypeError("currency pair should be a string")
+
+    if (typeof rate_ != "number")
+      throw new TypeError("rate should be a number")
+
     let now = new Date();
     if (currencyPair in this.ratesCache) {
       if (now > this.ratesCache[currencyPair].expiryDate) {

diff --git a/test/test.js b/test/test.js
@@ -214,6 +214,26 @@ describe("currencyConverter", () =>  {
             expect(() => currencyConverter.setupRatesCache(ratesCacheOptions)).to.throw(Error);
         })
     })
+
+    describe("addRateToRatesCache", () =>  {
+        it("should throw an error", () => {
+            let ratesCacheOptions = {
+                isRatesCaching: true,
+                ratesCacheDuration: 3600
+            }
+            currencyConverter.setupRatesCache(ratesCacheOptions);
+            expect(() => currencyConverter.addRateToRatesCache("USDCAD", "0.31")).to.throw(Error);
+        })
+
+        it("should throw an error", () => {
+            let ratesCacheOptions = {
+                isRatesCaching: true,
+                ratesCacheDuration: 3600
+            }
+            currencyConverter.setupRatesCache(ratesCacheOptions);
+            expect(() => currencyConverter.addRateToRatesCache(100, "0.31")).to.throw(Error);
+        })
+    })
 })
 
 // console.log(cf)