fix: added replaceAll method for older node versions #23

paul-shuvo · Mar 25, 2022 · 8eef7bf · 8eef7bf
1 parent 7c0273a
commit 8eef7bf
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -217,6 +217,19 @@ class CurrencyConverter {
         return this
     }
 
+    replaceAll(text, queryString, replaceString) {
+        let text_ = ""
+        for (let i = 0; i < text.length; i++) {
+            if (text[i] === queryString){
+                text_ += replaceString
+            }
+            else{
+                text_ += text[i]
+            }
+        }
+        return text_
+    }
+
     rates(){
         if(this.currencyFrom === this.currencyTo)
             return new Promise((resolve, _) => {resolve(this.currencyAmount) })
@@ -235,13 +248,13 @@ class CurrencyConverter {
                 .then((rates) => {
                     if(this.isDecimalComma){
                         if(rates.includes("."))
-                            rates = rates.replaceAll(".", "")
+                            rates = this.replaceAll(rates, ".", "")
                         if(rates.includes(","))
-                            rates = rates.replaceAll(",", ".")
+                            rates = this.replaceAll(rates, ",", ".")
                     }
                     else{
                         if(rates.includes(","))
-                            rates = rates.replaceAll(",", "")
+                            rates = this.replaceAll(rates, ",", "")
                     }
 
                     return parseFloat(rates)

diff --git a/package-lock.json b/package-lock.json
diff --git a/test/test.js b/test/test.js
@@ -114,6 +114,20 @@ describe("currencyConverter", () =>  {
         })
     })
 
+    describe("replaceAll", () => {
+        it("should replace all the , with empty space", () => {
+            assert.equal(currencyConverter.replaceAll("123,456,789.50", ",", ""), "123456789.50")
+        })
+
+        it("should replace all the , with empty .", () => {
+            assert.equal(currencyConverter.replaceAll("123456789,50", ",", "."), "123456789.50")
+        })
+
+        it("should replace all the . with empty space", () => {
+            assert.equal(currencyConverter.replaceAll("123.456.789", ".", ""), "123456789")
+        })
+    })
+
     describe("rates", () =>  {
         it("should not return undefined values", () => {
             currencyConverter.from("USD").to("JPY")