Fix override of product types

paul-tavares · Jul 24, 2023 · 96c45ae · 96c45ae
1 parent 627bb77
commit 96c45ae
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/x-pack/plugins/security_solution/scripts/run_cypress/parallel.ts b/x-pack/plugins/security_solution/scripts/run_cypress/parallel.ts
@@ -240,9 +240,16 @@ export const cli = () => {
 
                   if (configFromTestFile?.productTypes) {
                     vars.kbnTestServer.serverArgs.push(
-                      `--xpack.securitySolutionServerless.productTypes=${JSON.stringify(
-                        configFromTestFile.productTypes
-                      )}`
+                      `--xpack.securitySolutionServerless.productTypes=${JSON.stringify([
+                        ...configFromTestFile.productTypes,
+                        // Why spread it twice?
+                        // The `serverless.security.yml` file by default includes two product types as of this change.
+                        // Because it's an array, we need to ensure that existing values are "removed" and the ones
+                        // defined here are added. To do that, we duplicate the `productTypes` passed so that all array
+                        // elements in that ymal file are updated. The Security serverless plugin has code in place to
+                        // dedupe.
+                        ...configFromTestFile.productTypes,
+                      ])}`
                     );
                   }
                 } else if (configFromTestFile?.productTypes) {