Skip to content
This repository has been archived by the owner on Mar 20, 2022. It is now read-only.

index.d.ts should be located in the same directory as index.js (build) #178

Merged
merged 2 commits into from
Nov 27, 2016

Conversation

akomm
Copy link

@akomm akomm commented Nov 23, 2016

Fixes #146

Copy link
Owner

@paularmstrong paularmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two little things... Please remove index.d.ts from the files list in package.json

@@ -44,6 +44,7 @@
"babel-preset-es2015": "^6.18.0",
"babel-preset-stage-1": "^6.16.0",
"babel-register": "^6.18.0",
"copy-webpack-plugin": "^4.0.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run yarn to update the yarn.lock file.

@akomm
Copy link
Author

akomm commented Nov 24, 2016

Note, that webpack2 now handles correctly misplaced .d.ts importing the main file from package.json out of the box. In case of this package is pointing to the correct source (lib/index.js) matching the index.d.ts.

@paularmstrong paularmstrong merged commit 918166b into paularmstrong:master Nov 27, 2016
@zaycker
Copy link
Contributor

zaycker commented Dec 7, 2016

Guys, we are using webpack@1 and TypeScript@1.8.x and build is failed. Typescript compiler can't find module.
Changing path of .d.ts file to "typings": "lib/index.d.ts" in package.json fixes problem.
Help :)

@paularmstrong
Copy link
Owner

@zaycker I don't really have any experience with typescript and rely on the community for that. If you have a fix, please create a PR.

zaycker added a commit to zaycker/normalizr that referenced this pull request Dec 8, 2016
…er installation. but also this path has to be inside package.json. TS cannot resolve module path without right "typings" config
@lock
Copy link

lock bot commented May 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the Outdated label May 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants