Skip to content
This repository has been archived by the owner on Mar 20, 2022. It is now read-only.

Feature/constify #227

Merged
merged 2 commits into from Jan 30, 2017
Merged

Feature/constify #227

merged 2 commits into from Jan 30, 2017

Conversation

donavon
Copy link
Contributor

@donavon donavon commented Jan 25, 2017 •
edited

Problem

I saw some unnecessary let statements that could/should be const.

Solution

Converting to const made the code easier to read, smaller, and functional. The "compiled" code in dist is also smaller.

TODO

  • Add & update tests
  • Ensure CI is passing (lint, tests, flow)
  • Update relevant documentation

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling af261c1 on donavon:feature/constify into e365e51 on paularmstrong:master.

paularmstrong
paularmstrong approved these changes Jan 25, 2017
View reviewed changes
Copy link
Owner

@paularmstrong paularmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paularmstrong paularmstrong merged commit af261c1 into paularmstrong:master Jan 30, 2017
@lock
Copy link

lock bot commented May 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the Outdated label May 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paularmstrong paularmstrong paularmstrong approved these changes

Assignees
No one assigned
Labels
Outdated
Projects
None yet
Milestone
No milestone
3 participants
@donavon @coveralls @paularmstrong