This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Added support for nested block inheritance to Swig #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… existing parent item instead.
… nested unit tests.
…arried across extends tag.
…level function arguments as-is even though parameter is not used bcause this interface may be used by custom tags and removing the argument would potentially break existing custom tags.
… working and passes unit tests.
|
First, this is really awesome, Nick. I've been so busy with other obligations and projects that I haven't been able to focus on swig enough. Thanks for being so thorough with tests and lint cleanup!
It looks like you preserved the functionality that it was used for (finding the parent). I'm more than happy to just remove the argument--we're still in v0.X, so changes that break the API are be expected. Let's delete it! I'm just going to merge this, do some cleanup, documents, fix a couple super minor issues and get this out soon! |
paularmstrong
added a commit
that referenced
this pull request
Oct 20, 2012
Added support for nested block inheritance to Swig
Fixes #64
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes:
-Support for nested block inheritance
-Unit tests covering the nested block inheritance
-Fix for express demo server.js to work with latest version of express
-Additional demo views under express examples
State:
Unit tests passing including new nested unit tests.
Known issues:
I recommend taking a look at the interface for compile() within parser.js. An argument named parentBlock has been eliminated from the compile() function interface. Unfortunately, this compile interface is an exported interface and could have been used to create custom tags. I didn't want to change the interface as I'm not sure how far-reaching of an impact this would have. You may choose to clean up the interface and eliminate the argument, but I left the deprecated argument there so that you can make the call when doing a merge.
Let me know if you have any issues and I'll be happy to support.