Skip to content
This repository has been archived by the owner on Apr 11, 2018. It is now read-only.

bugfix for dead loop #162

Merged
merged 1 commit into from
Dec 20, 2012
Merged

bugfix for dead loop #162

merged 1 commit into from
Dec 20, 2012

Conversation

lepture
Copy link
Contributor

@lepture lepture commented Dec 10, 2012

if tpl is undefined, it will loop forever.

@paularmstrong
Copy link
Owner

Where is the test case that proves this is a problem?

@lepture
Copy link
Contributor Author

lepture commented Dec 10, 2012

it's obviously. you set root as an array, and you don't have the template in both, it will loop forever.

@lepture
Copy link
Contributor Author

lepture commented Dec 10, 2012

Actually you can't write a test case, coz it's a dead loop, just think about it. when i doing my own project, it stopped there, and I have to add some log to find out what's going on.

This need not test case, just proper mind. Besides Iam on my phone.

@lepture
Copy link
Contributor Author

lepture commented Dec 11, 2012

This snippet code is written by @nka11 , let's get @nka11 into this topic.

It's obviously just a mistaken by @nka11

@nka11
Copy link
Contributor

nka11 commented Dec 11, 2012

Hi,

@lepture you'r right, it's a beginner's mistake ;)

But @paularmstrong is right, a test is welcome. It should not fail with your patch. If the test has to fail (without your patch, it will hang the test suite)

nka11 added a commit to nka11/swig that referenced this pull request Dec 14, 2012
@nka11 nka11 mentioned this pull request Dec 14, 2012
@nka11
Copy link
Contributor

nka11 commented Dec 14, 2012

@lepture I have to thank you a lot, with this fix i can now continue a stalled dev beacause of this bug.

@paularmstrong paularmstrong merged commit ae3501a into paularmstrong:master Dec 20, 2012
@lepture lepture deleted the swig.loop branch December 20, 2012 05:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants