This repository has been archived by the owner on Apr 11, 2018. It is now read-only.
Added patch to call the callback passed into compileFile in the event of an error thrown in compile #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y compile and pass the error to callback
paularmstrong
added a commit
that referenced
this pull request
Oct 9, 2013
Catch errors and send to callback if compileFile fails.
|
Thank you for following lint and writing a new test! |
|
no problem. Glad to contribute! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a callback is passed into compileFile in swig.js, this patch catches any errors thrown when calling compile and invokes the callback with an error instead.
While this patch doesn't make sure all calls are async when a callback is specified (a minor issue), this patch does address the main crux of issue #338, which is to ensure the callback is called instead of having the error be thrown.