Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe block with empty message does not run #5

Closed
danger-ranger opened this issue Jan 5, 2017 · 6 comments
Closed

Describe block with empty message does not run #5

danger-ranger opened this issue Jan 5, 2017 · 6 comments

Comments

@danger-ranger
Copy link

e.g.

Describe("", () -> {
    It("stuff", () -> {
        assertThat(true).isTrue();
    });
});  

This won't run any tests

@danger-ranger
Copy link
Author

Not a big deal, it's just unexpected sometimes

@paulcwarren
Copy link
Owner

So, we suspect an empty Describe label? Will fix soonest. Thx for the issue.

@danger-ranger
Copy link
Author

Yeah. It's not exactly a valid use case, but

@paulcwarren
Copy link
Owner

Hey Gavin,
I started having a look at this today. When I attempt to run that test I get an IllegalArgumentException from the framework. I just wanted to check a couple of things. 1. you are seeing the same thing and 2. expected behavior from your point of view. Do you expect this to run (and obviously pass)? 3. what version of junit are you guys using there?

@danger-ranger
Copy link
Author

  1. Still seeing it, screenshots below.
  2. I would expect it to run tests whether or not some of the Describe blocks have empty messages. Failing that I would expect an error message instead of just "No tests were found"
  3. We're running ginkgo4j 1.0.7, junit 4.12

screen shot 2017-02-16 at 11 16 49 am
screen shot 2017-02-16 at 11 16 39 am

@paulcwarren
Copy link
Owner

Fixed. Will be in 1.0.8

paulcwarren pushed a commit that referenced this issue Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants