Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content-rest mappings hide data rest endpoints for "PATCH" and "HEAD" methods #53

Closed
bushaev opened this issue Dec 6, 2018 · 1 comment

Comments

@bushaev
Copy link

bushaev commented Dec 6, 2018

ContentHandlerMapping#lookupHandlerMethod returns lookup method for mapping, unfortunately because ContentHandlerMapping#isHalOrJsonRequest ignores "PATCH" and "HEAD" methods, rest endpoints created by Spring Data Rest get hidden and therefor it's impossible to perform "PATCH" update on "content entity" and "PUT" update with content-type header application/json erases file. It would be great if the support for these methods was added as well!

@paulcwarren
Copy link
Owner

Hi @bushaev, this sounds like a bug. Spring Content shouldn't be trampling on Spring Data endpoints. Especially if we dont yet use them ourselves. As an aside I have never been happy with that isHalOrJsonRequest as it precludes json from being content which in some use cases it might be. Anyways, we'll fix this.

paulcwarren pushed a commit that referenced this issue Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants