Correct content-disposition response header to be of type 'attachment' #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having Content-Disposition set to 'form-data' is only valid in multipart form submissions (in the request), never in a response. In a response, the content-disposition should only be set to either 'attachment' or 'inline'
|
Thanks Lars |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having Content-Disposition set to 'form-data' is only valid in multipart form submissions (in the request), never in a response.
In a response, the content-disposition should only be set to either 'attachment' or 'inline': https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#as_a_response_header_for_the_main_body
Given the
name="attachment"part of the current (incorrect) content-disposition header, I believe the goal was to havecontent-disposition: attachmentset as header.When there is no filename available for the content,
Content-Disposition: attachmentshould be set as well to always force a download of the content, otherwise a browser would fall back to the default (which isinline).Using
Content-Disposition: inlineis problematic for resources created by untrusted users: HTML pages can contain scripts that would run in the context of the API, so care should be taken to always setContent-Disposition: attachment.