Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unassociate and respective test units #30

Conversation

LadislavSopko
Copy link

Hello,

I made all unassiciate and unsetContent functions with the same logic for all stores.
Added also respective TestUnits.

Regards
ladislav

@coveralls
Copy link

coveralls commented Apr 20, 2018

Coverage Status

Coverage increased (+0.5%) to 81.504% when pulling 5ba70ad on LadislavSopko:feature/ladislav/adjustmongostore into 23ee7b1 on paulcwarren:wip/springboot2.

@LadislavSopko
Copy link
Author

Codacy is still there,
and detect wrongly static imports, and duplicated code in test units
which must be the same, if test the same on different implementations .....
It can be surely good service, but maybe it should not check tests?

@paulcwarren
Copy link
Owner

OK. I removed the project from codacy itself. The quality review is still there but if you try details it now produces an error so perhaps...maybe...it will now be gone!

@paulcwarren
Copy link
Owner

paulcwarren commented Apr 23, 2018

Does your first commit switch back to <plugins> and then the second switch back again to <pluginsManagement>?

If you are having issues with that in eclipse and the "Plugin execution not covered by lifecycle configuration" issue. It's because m2eclipse doesn't know about the asciidoc maven plugin and how or whether to configure it into the incremental build. You don't want to configure it into the incremental build. There are a couple of ways to ignore it. Usually I choose the quickfix that sets it to ignore in your workspace settings.

@LadislavSopko
Copy link
Author

LadislavSopko commented Apr 24, 2018

I removed <pluginsManagement> and setup eclipse wsp to ignore it.

@LadislavSopko
Copy link
Author

LOL,
Codacy popped UP again ?

@paulcwarren paulcwarren merged commit 40e7882 into paulcwarren:wip/springboot2 Apr 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants