Azurite TestContainer for Azure blob testing #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, can't help myself. I had to add a TC implementation for AWS. Also, I uncovered the issue causing the broken AWS test I mentioned before so I've fixed this as well. |
|
Nice to see your response re testcontainers, we use them a fair bit internally. Guess the good news would be that I have most of them already converted locally and working :) |
|
This also passed locally so merging this too. Thanks very much @andye2004 |
|
Hi @paulcwarren, I'll open another PR in the next day or two with all of the other test container conversion I have. |
|
Looking forward to seeing those. Thankyou |
paulcwarren
pushed a commit
that referenced
this pull request
Oct 27, 2021
* Azurite TestContainer for Azure blob testing * Add testconteiners for AWS, fix broken multi-tenant test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Paul, my curiosity got the better of me and I decided to look into the Azure docker container implementation.
It seemed obvious to me that it would be better to try it out with a real-world scenario, so I took the liberty of converting the Azure tests to use my test container implementation. There actually isn't much to this in the end but it now means the Azure tests could run without a pre-defined Azure set-up and would make development for spring-content noobs like myself easier moving forward.
I hope you don't mind that I have opened a PR but please feel free to reject it if this isn't a road you would want to go down.
Cheers, Andy.