Skip to content

Commit

Permalink
[stable/spinnaker] fix bug where spinnaker can't connect to minio
Browse files Browse the repository at this point in the history
As reported in spinnaker itself [here](spinnaker/spinnaker#4431),
It doesn't appear to affect the current stable build, but it has problems with the nightly builds.

This change should innoculate us from that bug if it makes it through to a stable build.

Effectively the issue is that in the newer builds of spinnaker it attempts to use domain paths
for s3 access.  This means instead of trying to connect to `spinnaker-minio/spinnaker` which should
be valid dns for the minio service it tries to connect to `spinnaker.spinnaker-minio` and fails because
this is not valid dns for minio.

Signed-off-by: Paul Czarkowski <username.taken@gmail.com>
  • Loading branch information
paulczar committed Jun 17, 2019
1 parent cef85e8 commit c094aea
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion stable/spinnaker/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: Open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.
name: spinnaker
version: 1.11.1
version: 1.11.2
appVersion: 1.12.5
home: http://spinnaker.io/
sources:
Expand Down
6 changes: 5 additions & 1 deletion stable/spinnaker/templates/configmap/halyard-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ data:
# Storage
{{ if .Values.minio.enabled }}
echo {{ .Values.minio.secretKey }} | $HAL_COMMAND config storage s3 edit --endpoint http://{{ .Release.Name }}-minio:9000 --access-key-id {{ .Values.minio.accessKey }} --secret-access-key --bucket {{ .Values.minio.bucket }}
echo {{ .Values.minio.secretKey }} | $HAL_COMMAND config storage s3 edit \
--endpoint http://{{ .Release.Name }}-minio:9000 \
--access-key-id {{ .Values.minio.accessKey }} \
--secret-access-key --bucket {{ .Values.minio.bucket }} \
--path-style-access
$HAL_COMMAND config storage edit --type s3
{{ end }}
{{ if .Values.s3.enabled }}
Expand Down

0 comments on commit c094aea

Please sign in to comment.