-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dart 2 invokeMethod compatibility #51
Comments
Seems like this is not fully finished. The |
I can submit a pull request but I need to know what is best practice (probably option 1). Option 1 Option 2 Thanks in advance! |
I think this issue needs to be reopened, as I am still getting errors when using |
After more thought I think option 1 (from @xqwzts) is better since it doesn't change the method signature. I will submit a pull request when I have a moment. |
With the upcoming Dart 2 changes we will run into errors when returning anything other than
Future<dynamic>
frominvokeMethod
calls.Calls like:
Need to be updated to:
More details in this issue: flutter/flutter#15654
The text was updated successfully, but these errors were encountered: