Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whether the library is still being maintained #929

Open
jahnli opened this issue Sep 2, 2021 · 22 comments
Open

Whether the library is still being maintained #929

jahnli opened this issue Sep 2, 2021 · 22 comments

Comments

@jahnli
Copy link

jahnli commented Sep 2, 2021

Whether the library is still being maintained

At present, it has not been updated for half a year, and more than 400 issues have not been processed

@keehoo
Copy link

keehoo commented Sep 8, 2021

Well. this is really werid, have anyone checked it seems like a version there is 0.8.0 and on githaby it's still 0.7.2 ?
The question remains though... Any good forks ?

@vborbely
Copy link

vborbely commented Sep 8, 2021 via email

@boskokg
Copy link

boskokg commented Sep 26, 2021

Like two years ago, I am creating a fork that will gather all critical updates.

Please write if you have some important things to add.

You can use:

flutter_blue:
git:
url: https://github.com/boskokg/flutter_blue/
ref: 0.9.0

0.9.0

  • Android migrate to mavenCentral.
  • Android support build on Macs M1
  • Android protobuf-gradle-plugin:0.8.15 -> 0.8.17
  • Ios example upgrade to latest flutter 2.5
  • deprecated/removed widgets fixed in example

@jahnli
Copy link
Author

jahnli commented Sep 26, 2021

@boskokg Will it be merged into pub?

@boskokg
Copy link

boskokg commented Sep 26, 2021

@jahnli It depends on the activity of the maintainer @pauldemarco
Two years ago, he reviewed the commits and updated the main plugin.
If there is no activity from him for some time, we can create a new plugin.

@peekpt
Copy link

peekpt commented Sep 27, 2021

@boskokg would you please implement this changes boskokg/flutter_blue@master...MZachmann:updater

@Scowley4
Copy link

@boskokg I'm all for everyone shifting work to a new fork of this repo. If we are migrating to your fork, will you turn on Issues for the fork?

@boskokg
Copy link

boskokg commented Sep 29, 2021

flutter_blue:
git:
url: https://github.com/boskokg/flutter_blue/
ref: 0.10.0

0.10.0
mtuRequest returns the negotiated MTU
Android: functions to turn on/off bluetooth
Android: add null check if channel is already teared down
Android: code small refactoring (fixed AS warnings)
Android: add null check if channel is already teared down
Ios: widen protobuf version allowed

@boskokg
Copy link

boskokg commented Sep 29, 2021

@peekpt I added most of the changes from the MZachmann:updater

I did not added background functionality since there was a discussion about the way it is done. @pauldemarco reviewed it then and did not apply the same changes.

You can read it here: #510 (comment)

I will check for other pull requests to apply.

@Scowley4 I will turn on the issues. Thanks

@peekpt
Copy link

peekpt commented Sep 29, 2021

@boskokg nice job, thank you!

Is there any fix for startScan() that is not filtering withServices: [Guid1,Guid2,...] correctly

@boskokg
Copy link

boskokg commented Sep 29, 2021

Thanks @peekpt

Not sure about startScan.

I am doing now the removal of v1Embedding, min flutter 2.5 and removal of Activity usage where possible for the people that use the plugin out of activity.

@peekpt Please let me know if you find any important merge requests.

@boskokg
Copy link

boskokg commented Sep 30, 2021

flutter_blue:
git:
url: https://github.com/boskokg/flutter_blue/
ref: 0.11.0

0.11.0

@jahnli
Copy link
Author

jahnli commented Sep 30, 2021

@boskokg

We look forward to you re creating a library for better maintenance

Consider publishing in pub.dev

@peekpt
Copy link

peekpt commented Oct 25, 2021

@boskokg #964

@boskokg
Copy link

boskokg commented Nov 21, 2021

0.13.0

0.12.0

@danopdev
Copy link

There will be a pub.dev push of this branch ?

@peekpt
Copy link

peekpt commented Nov 26, 2021

There will be a pub.dev push of this branch ?

You mean a merge of this fork? @boskokg said the author probably will do that

@sophisticode
Copy link

@peekpt @boskokg Was anyone of you in contact with the author? In case the author is not reachable, moving this branch to pub under a new plugin name should be considered.

@peekpt
Copy link

peekpt commented Nov 26, 2021

@peekpt @boskokg Was anyone of you in contact with the author? In case the author is not reachable, moving this branch to pub under a new plugin name should be considered.

Everything should be considered in open source

@objectiser
Copy link

@boskokg @peekpt If the fork is going to be used to create a new plugin name, could I suggest that the fork is moved to a github organization, rather than under a specific user's account, and have atleast two maintainers to avoid the same situation happening again in the future?

@boskokg
Copy link

boskokg commented Jan 31, 2022

I published flutter_blue_plus 1.0.0 with the latest code in the fork.

I will add @peekpt as a maintainer. Please suggest if someone else should be the maintainer.

The fork that we used for bug fixes will no longer be maintained since there is no need.

@jahnli
Copy link
Author

jahnli commented Feb 3, 2022

@boskokg Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants