Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unseekable streams #105

Merged
merged 17 commits into from Sep 12, 2022
Merged

Support unseekable streams #105

merged 17 commits into from Sep 12, 2022

Conversation

pauldmccarthy
Copy link
Owner

Fixes #102 and incorporates #103. Also adjusts logic in zran.c to remove dependence on knowing the size of the compressed stream.

@pauldmccarthy pauldmccarthy mentioned this pull request Sep 9, 2022
Closed
@pauldmccarthy
Copy link
Owner Author

@epicfaace removing the dependency on knowing the compressed size was much simpler than I had anticipated (I think). Is there any chance you could test these changes in your pipeline[s] before I publish?

epicfaace
epicfaace approved these changes Sep 10, 2022
View reviewed changes
Copy link
Contributor

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It's a bit hard for me to test unless I publish my own wheels / fork, but the test around exporting indexes seems comprehensive enough that I'm fairly confident this will work for my use case.

Thanks for doing this!!

indexed_gzip/tests/ctest_indexed_gzip.pyx Outdated Show resolved Hide resolved
indexed_gzip/zran_file_util.c Outdated Show resolved Hide resolved
indexed_gzip/zran.c Show resolved Hide resolved
indexed_gzip/zran.c Show resolved Hide resolved
@pauldmccarthy pauldmccarthy merged commit 42557f6 into master Sep 12, 2022
@pauldmccarthy pauldmccarthy deleted the enh/unseekable branch September 12, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epicfaace epicfaace epicfaace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't create indexes from un-seekable fileobj's
2 participants
@pauldmccarthy @epicfaace