ssh_connect.py: Fixed a bug with telnet connections where the port wa…

…sn't being properly converted to a string. This should fix the issue reported in liftoff#87

Playback Plugin:  Fixed a bug where you could get UnicodeDecodeErrors when exporting the current session recording.  This should fix the issue reported in liftoff#90

gateone/gateone.py

@@ -864,6 +864,10 @@ def get_current_user(self):
             return self.api_user
         user_json = self.get_secure_cookie("gateone_user")
         if not user_json:
+            if not self.settings['auth']:
+                # This can happen if the user's browser isn't allowing
+                # persistent cookies (e.g. incognito mode)
+                return {'upn': 'ANONYMOUS', 'session': generate_session_id()}
             return None
         return json_decode(user_json)
 

gateone/plugins/playback/playback.py

@@ -87,8 +87,6 @@ def save_recording(settings, tws):
         templates_path, "self_contained_recording.html")
     with open(recording_template_path) as f:
         recording_template_data = f.read()
-    with open('/tmp/recording.json', 'w') as f:
-        f.write(recording)
     recording_template = tornado.template.Template(recording_template_data)
     rendered_recording = recording_template.generate(
         recording=recording,

gateone/plugins/ssh/scripts/ssh_connect.py

@@ -429,7 +429,7 @@ def telnet_connect(user, host, port=23, env=None):
     else:
         env['PATH'] = os.environ['PATH']
         command = which("telnet")
-    args = [host, port]
+    args = [host, str(port)]
     if user:
         args.insert(0, user)
         args.insert(0, "-l")
@@ -759,7 +759,7 @@ def parse_ssh_url(url):
     except KeyboardInterrupt:
         print(_("\nKeyboardInterrupt detected.  Quitting..."))
     except Exception as e: # Catch all
-        print(_("Got Exception trying to run openssh_connect: %s" % e))
+        print(_("Got Exception: %s" % e))
         import traceback
         traceback.print_exc(file=sys.stdout)
         print("Please open up a new issue at https://github.com/liftoff"