Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possibly wrong log return in polytope with make_center #1

Open
pauleaster opened this issue Nov 2, 2021 · 1 comment
Open

Possibly wrong log return in polytope with make_center #1

pauleaster opened this issue Nov 2, 2021 · 1 comment

Comments

@pauleaster
Copy link
Owner

There appears to be some inconsistency with make_center, for a tabulated equation of state (p,h) is returned whereas, for the polytropic equation of state, it looks like p and the natural log of h is returned! I haven't got the EoS relationships at hand so this needs to be checked later.
@pauleaster
Copy link
Owner Author

The log has been removed from the return value for h for polytropic equations of state. make_center returns (p,h) same as the tabulated EoS.

...Note that these values are non-dimensionalised.
See load_eos to see what the scaling is.

pauleaster added a commit that referenced this issue Nov 2, 2021
@pauleaster
make_center finished including tests. Renamed rho to e in tabulated E…
cc6e056 
…oS, Issue #1. Removed the log from the enthalpy output, Issue #2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pauleaster