Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small note in README to close client #23

Merged
merged 1 commit into from
Oct 21, 2016
Merged

Small note in README to close client #23

merged 1 commit into from
Oct 21, 2016

Conversation

michaelzg
Copy link
Contributor

Ran into the warning below on app shutdown. Added a small tip in the README connection section as a quick tip to clean up.

AsyncHttpClient.close() hasn't been invoked, which may produce file descriptor leaks

@codecov-io
Copy link

codecov-io commented Oct 21, 2016

Current coverage is 100% (diff: 100%)

Merging #23 into master will not change coverage

@@           master   #23   diff @@
===================================
  Files          14    14          
  Lines         197   197          
  Methods       178   166    -12   
  Messages        0     0          
  Branches       19    31    +12   
===================================
  Hits          197   197          
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 83d9528...d360358

@paulgoldbaum
Copy link
Owner

Thanks for the patch Michael!

@paulgoldbaum paulgoldbaum merged commit f1c8b2a into paulgoldbaum:master Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants