Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<lite-vimeo> #34

Closed
luwes opened this issue Dec 16, 2019 · 2 comments
Closed

<lite-vimeo> #34

luwes opened this issue Dec 16, 2019 · 2 comments

Comments

@luwes
Copy link
Contributor

luwes commented Dec 16, 2019

My apologies for jumping on this so quickly but I thought it was a very cool project (added the Apache-2.0 license mentioned in #31) I started a fork for the Vimeo player which has some small improvements I think around configuration and including CSS in the JS bundle unless you decide to go a different route. would be cool to have no need for build tools but not sure if that's doable.

Feel free to close this issue, just wanted to ping here. Cheers!

Link: https://github.com/luwes/lite-vimeo-embed
@paulirish
Copy link
Owner

@luwes that's badass. can you give me a PR to add this to the readme?

@luwes luwes mentioned this issue Dec 18, 2019
Merged
@luwes
Copy link
Contributor Author

luwes commented Dec 19, 2019

Will close this one here, thanks @paulirish! 🙌

@luwes luwes closed this as completed Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @luwes