Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.5x performance boost #16

Closed
wants to merge 2 commits into from
Closed

2.5x performance boost #16

wants to merge 2 commits into from

Conversation

pmdartus
Copy link
Collaborator

@pmdartus pmdartus commented Apr 24, 2016 •
edited
Loading

The _histogram cache in the frames objects was never hit, because of the way promises are scheduled.

Solved by making the getHistogram() method synchronous.

Before:
screen shot 2016-04-24 at 15 08 40
After:
screen shot 2016-04-24 at 15 08 28

@pmdartus pmdartus mentioned this pull request Apr 24, 2016
Merged
@samccone
Copy link
Collaborator

👏 so good, awesome stuff here @pmdartus

@paulirish
Copy link
Owner

so so good

@samccone
Copy link
Collaborator

@pmdartus looks like we just need a rebase on this 🎱

@pmdartus pmdartus closed this Apr 28, 2016
@pmdartus
Copy link
Collaborator Author

Rebased and merged into the master.
The fix has landed into 0.1.2.

@samccone samccone deleted the perf-boost branch April 28, 2016 07:08
@samccone
Copy link
Collaborator

hero

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmdartus @samccone @paulirish