#23 - Update Travis to run func tests on build #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added sbt-native-packager plugin to build standalone jar, so we don't have deal with nested processes started by sbt. Travis now builds jar package using native packager and than starts build script. Build script also waits for server to terminate after functional tests are run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not that great with bash scripting, but here is my attempt to make this work.
Travis build now runs
sbt stage, that builds standalone jar and start script.This si important because
sbt runstarts subprocess and we don't have its pid and can't properly terminate it. New build starts application from standalone jar, which means thatSERVER_PIDcontains pid of application process, not sbt.