Add initial support for Markdown #13
Conversation
src/parse-markdown/index.ts
Outdated
| @@ -22,7 +30,11 @@ export default function parseMarkdown(md: string, fname: string) { | |||
| lineHtml += `<h1>${parsedParagraph}</h1>`; | |||
| title = parsedParagraph; // Set <title> tag | |||
| } else { | |||
| lineHtml += `<p>${parsedParagraph}</p>`; | |||
| if (parsedParagraph.startsWith("<h2>") && parsedParagraph.endsWith("</h2>")) { | |||
| lineHtml += `${parsedParagraph}`; | |||
There was a problem hiding this comment.
No need for template syntax, can simply do:
lineHtml += parsedParagraph;|
|
||
| const headingTwoPattern = /^( {0,3}##\s+.*)/; | ||
| html = html.replace(headingTwoPattern, (match, headingTwoText) => { | ||
| let headingTwo = headingTwoText.split(/##/).slice(1).join("##").trim(); |
There was a problem hiding this comment.
I prefer using const whenever possible if a value does not need to be mutated within its scope.
|
|
||
| const headingTwoPattern2 = /^(.*\n {0,3}-+\s*)/; | ||
| html = html.replace(headingTwoPattern2, (match, headingTwoText) => { | ||
| let altHeadingTwo = headingTwoText.split(/\n/)[0].trim(); |
There was a problem hiding this comment.
I prefer using const whenever possible if a value does not need to be mutated within its scope. I'd also prefer using the same variable headingTwo like last time since it's a good variable name and the two scopes are distinct.
src/parse-markdown/index.ts
Outdated
| @@ -9,6 +9,14 @@ export default function parseMarkdown(md: string, fname: string) { | |||
| const hasTitle = | |||
| paragraphs[0].length > 0 && paragraphs[1] === "" && paragraphs[2] === ""; | |||
|
|
|||
| // Check for alternative Heading Two syntax | |||
| for (let i = 0; i < paragraphs.length; i++) { | |||
There was a problem hiding this comment.
Can eliminate checking for condition i < paragraphs.length - 1 by limiting the iteration condition.
Example:
for (let i = 0; i < (paragraphs.length - 1); i++) {
if (i < paragraphs[i + 1].match(/^( {0,3}-+\s*)$/) !== null) {
paragraphs[i] = `${paragraphs[i]}\n${paragraphs[i + 1]}`;
paragraphs[i + 1] = "";
}
}
src/parse-markdown/index.ts
Outdated
| @@ -9,6 +9,14 @@ export default function parseMarkdown(md: string, fname: string) { | |||
| const hasTitle = | |||
| paragraphs[0].length > 0 && paragraphs[1] === "" && paragraphs[2] === ""; | |||
|
|
|||
| // Check for alternative Heading Two syntax | |||
| for (let i = 0; i < paragraphs.length; i++) { | |||
| if (i < paragraphs.length - 1 && paragraphs[i + 1].match(/^( {0,3}-+\s*)$/) != null) { | |||
There was a problem hiding this comment.
Strict type checking operators are preferred (!==)
|
I have completed making the necessary changes. |
Resolves #9
parseArguments.tsto also check if input path ends in.mdparseHeadingTwo.tsfile inside./src/parse-markdownfolder and added function to replace Heading 2 markdown syntax with appropriate<h2>...</h2>HTML tag./src/parse-markdown/index.ts, the input text is being split into singular lines, but since the alternative Heading 2 syntax is based on two lines (alternate syntax is having a form of---on the line after the desired Heading 2 line), I needed to join back the lines that matched this type of syntax, and then push it to theparseBlock(paragraph)functionparseBlock.tsto runparseHeadingTwofunction withinparseBlockfunction.mdsample files inside ./examples folder