feat: update current remote description with fingerprint #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a `currentRemoteDescription` field to `PeerConnection` which can be updated independently of `remoteDescription`, the idea being the `remoteDescription` is the offer received from the remote peer and the `currentRemoteDescription` is what has actually been negotiated with them. The `currentRemoteDescription` is initialised when the `remoteDescription` is set. Currently the `checkFingerprint` method updates the certificate fingerprint used by the connection to the remote peer but I guess other modifications may be useful. Exposes the `currentRemoteDescription` via a getter similar to `remoteDescription`.
achingbrain
added a commit
to achingbrain/node-datachannel
that referenced
this pull request
Jun 7, 2024
Retrieves the current remote description from libdatachannel to get the current state of the connection negotiation instead of returning the previously set remote description. Depends on: paullouisageneau/libdatachannel#1204
This was referenced Jun 7, 2024
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jun 7, 2024
Supports listening and dialing WebRTC Direct multiaddrs in Node.js. Depends on: - [ ] libp2p/go-libp2p#2827 - [ ] paullouisageneau/libdatachannel#1201 - [ ] paullouisageneau/libdatachannel#1204 - [ ] murat-dogan/node-datachannel#257 - [ ] murat-dogan/node-datachannel#256 Closes: - #2581
12 tasks
achingbrain
added a commit
to libp2p/js-libp2p
that referenced
this pull request
Jun 7, 2024
Supports listening and dialing WebRTC Direct multiaddrs in Node.js. Depends on: - [ ] libp2p/go-libp2p#2827 - [ ] paullouisageneau/libdatachannel#1201 - [ ] paullouisageneau/libdatachannel#1204 - [ ] murat-dogan/node-datachannel#257 - [ ] murat-dogan/node-datachannel#256 Closes: - #2581
|
Superseded by #1206 |
achingbrain
deleted the
feat/update-current-remote-description-with-fingerprint
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
currentRemoteDescriptionfield toPeerConnectionwhich can be updated independently ofremoteDescription, the idea being theremoteDescriptionis the offer received from the remote peer and thecurrentRemoteDescriptionis what has actually been negotiated with them.The
currentRemoteDescriptionis initialised when theremoteDescriptionis set.Currently the
checkFingerprintmethod updates the certificate fingerprint used by the connection to the remote peer but I guess other modifications may be useful.Exposes the
currentRemoteDescriptionvia a getter similar toremoteDescription.Closes #1203
Refs #1166