Ignore TURN servers with transport TCP or TLS with libjuice #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior with libjuice as ICE backend is to attempt to reach all TURN servers over UDP, even when TCP or TLS transport is specified. This can be problematic in the case of non-trickled ICE, as the TURN server might not be reachable over UDP (for instance, some providers have TCP-only TURN servers), inducing a long timeout delay before connection.
This PR changes the behavior to ignore TURN servers with TCP and TLS transports with libjuice. The behavior with libnice is unchanged.