topojson #33
Closed
topojson #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertcuykens
force-pushed
the
master
branch
2 times, most recently
from
a5bc555
to
ee4360a
Compare
|
It's been a while, but since this is A LOT of code, +6000 lines, I don't think this should be merged directly into orb. I recommend forking https://github.com/rubenv/topojson, then adding these changes on top, then we can link that package from the readmes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements https://github.com/topojson/topojson-specification and is a modified version of https://github.com/rubenv/topojson to make use of orb. Please take a look to see what would be the best way to integrate this with the orb repo. Thanks