Improve template

paulmasson · Oct 11, 2017 · 62f0539 · 62f0539
1 parent d2ed595
commit 62f0539
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 10 deletions.
diff --git a/build/mathcell.js b/build/mathcell.js
@@ -1191,7 +1191,7 @@ function template( options, bounds, lights, texts, points, lines, surfaces ) {
     var box = new THREE.Geometry();
     box.vertices.push( new THREE.Vector3( a[0]*b0[0], a[1]*b0[1], a[2]*b0[2] ) );
     box.vertices.push( new THREE.Vector3( a[0]*b1[0], a[1]*b1[1], a[2]*b1[2] ) );
-    var boxMesh = new THREE.LineSegments( box );
+    var boxMesh = new THREE.Line( box );
     if ( options.frame ) scene.add( new THREE.BoxHelper( boxMesh, 'black' ) );
 
     if ( options.axesLabels ) {
@@ -1332,19 +1332,17 @@ function template( options, bounds, lights, texts, points, lines, surfaces ) {
 
     function addLine( json ) {
         var geometry = new THREE.Geometry();
-        for ( var i=0 ; i < json.points.length - 1 ; i++ ) {
+        for ( var i=0 ; i < json.points.length ; i++ ) {
             var v = json.points[i];
             geometry.vertices.push( new THREE.Vector3( a[0]*v[0], a[1]*v[1], a[2]*v[2] ) );
-            var v = json.points[i+1];
-            geometry.vertices.push( new THREE.Vector3( a[0]*v[0], a[1]*v[1], a[2]*v[2] ) );
         }
 
         var transparent = json.opacity < 1 ? true : false;
         var material = new THREE.LineBasicMaterial( { color: json.color, linewidth: json.linewidth,
                                                       transparent: transparent, opacity: json.opacity } );
 
         var c = geometry.center().multiplyScalar( -1 );
-        var mesh = new THREE.LineSegments( geometry, material );
+        var mesh = new THREE.Line( geometry, material );
         mesh.position.set( c.x, c.y, c.z );
         scene.add( mesh );
     }

diff --git a/src/plot/threejs-template.js b/src/plot/threejs-template.js
@@ -66,7 +66,7 @@ function template( options, bounds, lights, texts, points, lines, surfaces ) {
     var box = new THREE.Geometry();
     box.vertices.push( new THREE.Vector3( a[0]*b0[0], a[1]*b0[1], a[2]*b0[2] ) );
     box.vertices.push( new THREE.Vector3( a[0]*b1[0], a[1]*b1[1], a[2]*b1[2] ) );
-    var boxMesh = new THREE.LineSegments( box );
+    var boxMesh = new THREE.Line( box );
     if ( options.frame ) scene.add( new THREE.BoxHelper( boxMesh, 'black' ) );
 
     if ( options.axesLabels ) {
@@ -207,19 +207,17 @@ function template( options, bounds, lights, texts, points, lines, surfaces ) {
 
     function addLine( json ) {
         var geometry = new THREE.Geometry();
-        for ( var i=0 ; i < json.points.length - 1 ; i++ ) {
+        for ( var i=0 ; i < json.points.length ; i++ ) {
             var v = json.points[i];
             geometry.vertices.push( new THREE.Vector3( a[0]*v[0], a[1]*v[1], a[2]*v[2] ) );
-            var v = json.points[i+1];
-            geometry.vertices.push( new THREE.Vector3( a[0]*v[0], a[1]*v[1], a[2]*v[2] ) );
         }
 
         var transparent = json.opacity < 1 ? true : false;
         var material = new THREE.LineBasicMaterial( { color: json.color, linewidth: json.linewidth,
                                                       transparent: transparent, opacity: json.opacity } );
 
         var c = geometry.center().multiplyScalar( -1 );
-        var mesh = new THREE.LineSegments( geometry, material );
+        var mesh = new THREE.Line( geometry, material );
         mesh.position.set( c.x, c.y, c.z );
         scene.add( mesh );
     }